Bugs in libraries when using Firefox

Submitted by Anttik on Thu, 12/08/2016 - 20:09
Forums: 
Bugs in content types

Firefox freezes when using the newest library "official-h5p-release-20161206_0"

"A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue."

  1. Install lates 1.22 Drupal h5p module
  2. Install all libraries "official-h5p-release-20161206_0"
  3. Create question set with multiple choise questions
  4. test with firefox on windows 10

 

After uninstall and using this library "official-h5p-release-20161020"  problem disappeared

thomasmars's picture

thomasmars

Fri, 12/09/2016 - 13:23

I was not able to reproduce this with the setup you described.
There was a dependency issue with the first release of the official-h5p-release-20161206, but this should likely not have produced this output. Do you have some additional info/error messages from the console of when the script stopped ?

The dependency issue has since been fixed and can be grabbed at https://h5p.org/update-all-content-types, let me know if you continue experiencing this problem and can provide some additional debug information.

- Thomas

spazfox

Thu, 12/15/2016 - 18:19

I'm experiencing the same problem (on Mac using Firefox 50.1.0). The script that Firefox is saying is unresponsive is this: Script: https://foxylearning.com/sites…s/h5p/library/js/h5p.js?oi8kma:1056

You can see the problem live (to gather additional info from console, etc.) here: https://foxylearning.com/tutorials/vb/5/216548-1006

spazfox

Thu, 12/15/2016 - 22:17

FYI: So far I've noticed that this error seems to be happening only with Question Set content. 

thomasmars's picture

thomasmars

Fri, 12/16/2016 - 09:20

I'm not able to reproduce this with Windows 10 and FireFox 50.1.0.
Can you provide some additional information on how to reproduce it and what the error message says, where the script is unresponsive.
Do you have any extensions enabled ? They may be interfering and causing this issue.
This may also happen when FireFox thinks a script is taking too long to execute because it is doing some heavy work: https://support.mozilla.org/no/kb/warning-unresponsive-script, so it might be a performance/optimization issue.

- Thomas

spazfox

Fri, 12/16/2016 - 17:42

Thanks. I'm not able to reproduce it on Windows, either, but it continues to happen using Firefox 50 on Mac OS (tried with both Sierra and El Capitan). I was able to reproduce it on several different machines (with different and no extensions enabled). Here is the exact text of the error message:

Warning: Unresponsive script. A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue. 

Attempting to debug the script or letting it continue just results in Firefox continuing to hang. 

 

tim's picture

tim

Mon, 12/19/2016 - 09:14

Hi, I've managed to see the bug on your website and I think it has something to do with the way Question Set handles copyrights. I haven't been able to reproduce it locally. Would you be able to download and attach the question set (with the copyrights in the same locations)? 

Thanks,

Tim

spazfox

Mon, 12/19/2016 - 16:22

Thanks, Tim. I've created a simple, two-question question set (with no copyright info added or changed) and the problem persists: https://foxylearning.com/qsbug

I'm attaching the h5p file for the question set to this post. In case it matters, I'm running H5P on a Drupal 7 site with a Bootstrap-based theme. Thanks for looking into this!

H5P file: 
Binary Data qs-bug-300580.h5p
tim's picture

tim

Tue, 12/20/2016 - 15:52

Hi, spazfox I've tracked down the bug and the fix should be included soon. Thanks for reporting it! In the meantime, if you have access to the code you could add a 'return' statement in h5p.js in the drupal/sites/all/modules/h5p/library/js:

https://github.com/h5p/h5p-php-library/commit/b91be29cec8500fd1221faae651b0d4930d92ad9

Link to the issue:

https://h5ptechnology.atlassian.net/browse/HFP-391

spazfox

Wed, 12/21/2016 - 17:53

Thanks, that fixed it! 

thomasmars's picture

thomasmars

Thu, 12/22/2016 - 11:00

Hi spazfox,
if you have implemented Tim's solution you should be aware that it won't show all your copyrighted info if you have provided it for your content.
I have implemented a new solution for it that will take this into account. You can see https://h5ptechnology.atlassian.net/browse/HFP-391 if you would like to learn more about it.

- Thomas