Picture Slider


Trying again (now the upload file is available on this forum).

H5P file: 

If I am watching picture 1 and then clicks on circle 5 to display picture 5 the slider instantly jumps to picture 4 and then shows a transition between picture 4 and 5. The expected behaviour would be a transition directly from picture 1 to 5, or instantly switch to picture 5.

Why does the images have a title? The title doesn't seem to be used. Maybe it could be removed, or used as the header?

We can't be sure that there already exists H1, H2 and H3 tags in the page. Because of this the first Hx tag in an H5P must be H2 (We can be pretty sure that the page where the H5P is beeing embedded has an H1 tag)

For some reason the last image in the H5P editor is displayed as the first image in the picture slider. (I don't know if this was true after uploading the H5P file for the first time, but it happende after I added a few images of my own to the Picture slider I got after uploading your H5P file)

Only one of the CarouFredSel files seems to be in use. You may choose to remove the other files from the library.

The coding standards for H5P isn't well documented yet, but there are a couple of things we want to be consistent on:

  1. Indentation should always be 2 spaces
  2. Allways camelcase, never use underscores in variabel names (as_imagewidth -> asImageWidth)

There are five minor things that should be improved in order for this H5P to be approved.

Overall this H5P works like a charm and will be a great contribution to the H5P ecosystems. We thank you for contributing this H5P on H5P.org and hope you'll find the time to fix the bugs mentioned above so that we may approve your developer account on H5P.org.

Fixed the minor bugs.

H5P file: 

All reported bugs is fixed.

H5P file: 

Congratulations, your H5P has been approved and you're account have been upgraded to H5P Developer allowing you to share your work here at H5P.org :)

21cccs's picture

I don't see any documentation on this so wasn't sure if Picture Slider is a working module, but I attempted to make onw (https://h5p.org/node/48856) but to me it appears 10 pixels high. Anything I may be doing wrong?

tim's picture

Hi, I think picture slider maybe out of date. If its not on the examples page, its probably not supported. 

Hopefully the original developer could answer your question.

if the author call the iframe in his web an accesssible name for the iframe should be present so Assistive Technology user like screen to navigate it. i think title="image slider" resolve this issue

<iframe src="https://h5p.org/h5p/embed/128905" title="image slider" width="658" height="381" frameborder="0" allowfullscreen="allowfullscreen"></iframe><script src="https://h5p.org/sites/all/modules/h5p/library/js/h5p-resizer.js" charset="UTF-8"></script>