Accordion - Images feature

Submitted by david.delco on Thu, 01/02/2020 - 09:18
david.delco's picture
Forums: 
Feature requests

Hi and happy new year!

It would be great to have the possibility to add images (or other media) into panels of the accordion style content type!

Thank you.

David

5
0
Supporter votes Members of the Supporter Network can vote for feature requests. When the supporter network has generated sufficient funding for the top voted feature request it will normally be implemented and released. More about the H5P Supporter Network
BV52's picture

BV52

Thu, 01/02/2020 - 17:37

Hi David,

Happy New Year!

Thank you for contributing your ideas on how to make H5P better! With the H5P supporter program the H5P community can now vote for and fund the top voted H5P features.. Also there are developers in the community who every now and then works on a feature they find interesting or useful.

-BV

papi Jo's picture

papi Jo

Fri, 01/03/2020 - 18:46

@david.delco

This feature has been already requested:

Maybe it will be implemented in 2020... or in 2050... Who knows?

otacke's picture

otacke

Fri, 01/03/2020 - 19:25

Hi @all!

The code is there already, see https://github.com/h5p/h5p-accordion/pull/33

I don't know, however, when the H5P core team will find the time to review the code. It's not a great situation, but H5P is still openly sourced (you can customize your own system) and you cannot expect the core team to implement/accept every request/code donation.

Best,

Oliver

david.delco's picture

david.delco

Fri, 01/03/2020 - 19:49

Hi Oliver and thank you for your reply.

Of course, I know these issues, common to many open source software and certainly I have no pretensions in this regard. I would love to be able to collaborate more, perhaps proposing some changes or new codes, but I leave this thing to those who have the skills. Unfortunately, I can only submit requests or suggestions and hope that they will be accepted ... we will see. Anyway congratulations to all and thank you for creating H5P!

:-)

David

otacke's picture

otacke

Fri, 01/03/2020 - 22:43

Hi David!

Sorry if I offended you. I'm fully aware that not everyone can code and that asking for features is all you can do. I was just triggered by the resignation of Papi Jo - that I absolutely understand - but I also wanted to try to touch the reasons for why it is the way it is.

Best,

Oliver 

david.delco's picture

david.delco

Fri, 01/03/2020 - 23:05

Hi Oliver,

No, no, you didn't offend me. I Understand your mail. Maybe the translation of my thought from Italian into English was not perfect ... :-)

However, if I have the time to do it, I would like to learn some code ... maybe someone offers courses made with H5P tools?

Another "little" question: Why images ar fully large and is not possible to resize?

I am creating content for a course and I am trying to understand whether to use an H5P tool or the Moodle book function. H5P is very attractive as a tool package, I really like it. With Column I can insert quizzes alternating with parts of content and this is the functionality that most of all I would like to implement. But in Moodle's book (or pages) tool I can insert (and resize / position) images that explain parts of text ... I'm undecided. LOL

 

otacke's picture

otacke

Sat, 01/04/2020 - 14:22

Hi David!

Sorry, I don't know of anyone offering courses on coding with H5P, but any good course on web development (JavaScript) should be a good start. I think that Daniel Shiffman aka Coding Train provides great videos covering many aspects of coding with JavaScript and coding in general.

By default, H5P always scales content to the full width that's available. There are already two tickets in the core team's issue management system that are adressing this subject (https://h5ptechnology.atlassian.net/browse/HFP-1416 and https://h5ptechnology.atlassian.net/browse/HFP-1926), but I don't know when those will be tackled.

There have also been ideas for a "Row" content type, that when mixed with "Column" could give you more layout options (could also be a separate content type), but I am not sure if there are plans by the core team or someone from the community to actually build that one.

Best,
Oliver

david.delco's picture

david.delco

Fri, 01/03/2020 - 19:35

Thank you ;-)

cfp

Sat, 07/31/2021 - 12:57

Unless I'm missing it or my system isn't up-to-date it still isn't possible to add images to accordion. It's far from ideal but what I've done as a workaround is to create an accordion in the Lumi app, export the accordion as an html file and then, by editing that file in a text editor, added the image that way.

https://turnipeater.github.io/AccordionDemo1.html

Using the same method I was able to add an iFrame into the accordion.

https://turnipeater.github.io/AccordionDemo2.html

otacke's picture

otacke

Tue, 08/03/2021 - 00:23

Hi!

You are correct. There's a pull-request that would allow to include subcontent in Accordion (https://github.com/h5p/h5p-accordion/pull/41), but the H5P core team will have to decide about it, merge the code into the official code base and release an update.

Best,

Oliver