Branching scenario does not work in full screen

erlend's picture

1. Open https://h5p.org/branching-scenario

2. Go full screen and play the game

3. When the video stops and you are supposed to choose what to do, nothing appears on the screen.

4. Go out of full screen -> the question is now displayed.

BV52's picture

Hi erlend,

  1. What device are you using?
  2. What browser and version?

Please note that currently Branching scenario is not fully compatible with mobile devices.

-BV52

erlend's picture

MacOs Mojave 10.14

Google chrome Versjon 72.0.3626.121 

Safari Versjon 12.0 (14606.1.36.1.9)

It works in firefox.

 

BV52's picture

Hi erlend,

This is working on my end. Can you please check the following:

  1. Any errros in the browser console.
  2. Disable plugins in the browser
  3. Use Incognito mode
  4. Please attach a screenshot on what you are seeing.

-BV52

erlend's picture

I followed the steps above, but the questions still do not appear. There are no messages in the console. I stepped through the javascript code and found that when not in full screen, the questions appear when this line is executed: wrapper.appendChild(branchingQuestion);

When in full screen, nothing happens when the same line is executed. The element seems to be added correctly and when I select the elements view, I can see a rectangle highlight. It looks like it is hidden behind the the video? 

I have made a screen recording of what it looks like: https://youtu.be/6fSNRev8lgI

procademy's picture

Same here!

I did some cross browser testing, I noticed that the full screen mode is only available in Edge and Google Chrome (but doesn't show the question in full screen). Is it possible to add the full screen mode also in IE(11), Firefox (66), Safari (12)?

 

Great content type though!! :-)

procademy's picture

Small correction: I noticed that the top left full screen works correctly, bottom right (in playbar) doesn't. The bottom right full-screen mode only appears in chrome & edge, when activated no question pop-up appears. (I've added a screenshot)

 

I like the position of the full screen icon in the playbar, perhaps most intuitive for users? Would be nice if the full screen mode can be fixed over there :)

 

BV52's picture

Hi procademy,

Thank you for checking this in depth I didn't check the other full screen button. I filed a bug report and you follow the progress here.

-BV52

erlend's picture

And I didn't even notice the full screen button in the top left corner. Wouldn't it be better to have it in the bottom right corner? That is were people expect to find it?

BV52's picture

Hi erlend,

I actually used the one on the top left that's why I was not able to reproduce the issue initially. If I'm not mistaken we have that feature because it places the whole branching scenario in full screen instead of just the video.

-BV52

procademy's picture

Hi BV52, Exactly my experience but I the other way around, I only noticed the bottom right option :)

If you compare other H5P content types then the full screen mode is bottom right (Course Presentation, Interactive Video) or top right (Image Hotspots, Iframe Embedder, Image Slider, Impressive Presentation (ALPHA), Timeline, Virtual Tour (360)). So top right is the most common place for the full screen mode. Only the Branching Scenario places the icon top left. It would be great for consistency and intuitive use if the icon can be moved to the top right area :)

In case of the bottom right (Course Presentation, Interactive Video) the full screen icon is placed inside the playbar, that exception is understandable.  

 

 

)

 

BV52's picture

Hi procademy,

I totally agree with your observation. Since this thread is for the bug report would you mind posting a separate feature request

-BV52

procademy's picture

no prob!