Image Multiple Hotspot

Submitted by lukemuller on Fri, 02/24/2017 - 03:36
Forums: 
Developers

Hi Guys,

Based on the Image Hotspot content type, I've modified the code to allow for multiple hotspots as requested by a few users in the comments. Let me know what you guys think. Credit goes mostly to Joubel AS for all his work with the original Image Hotspot.

I've attached the H5P content to this post but the code can be found in both the repositories below:

Editor: https://github.com/lukemuller/h5p-editor-image-multiple-hotspot-question

Content Type: https://github.com/lukemuller/h5p-image-multiple-hotspot-question

Thanks

Luke

H5P file: 
Binary Data H5P.ImageMultipleHotspotQuestion-1.0.h5p
Attachments: 
Binary Data H5PEditor.ImageMultipleHotspotQuestion-1.0.h5p
Content types: 
Image Hotspots
fnoks's picture

fnoks

Fri, 02/24/2017 - 08:51

That's cool, lukemuller! I did a quick test, and it behaved really nicely. Only had to change widget to imageMultipleHotspotQuestion (was: imageHotspotQuestion) in semantics.json.

If you'd like, we can do a more thoroughly review of it?

-fnoks-

lukemuller

Sat, 02/25/2017 - 03:14

That would be great if you could, please go off the code in my attached github repositories as I updated it with the correct semantics and also added an additional user input check.

Thanks

Luke

fnoks's picture

fnoks

Mon, 02/27/2017 - 08:46

Great! I have created an issue for reviewing this new content type (https://h5ptechnology.atlassian.net/browse/HFP-790)

falcon's picture

falcon

Mon, 02/27/2017 - 11:42

Cool! Will be reviewed after the next release if not sooner.

thomasmars's picture

thomasmars

Wed, 03/15/2017 - 13:33

Hi Luke, I have reviewed the content type and it works very well. I like it a lot.
We could potentially release it as is, but I have a couple of notes that you may want to consider before going there:

1) When I click a hotspot that I have created that is wrong, the standard message for when clicking outside a hotspot is displayed instead of the message I supplied for the incorrect hotspot. The incorrect hotspot message should've shown.

2) If I click on an already showing hotspot-feedback of a hotspot (correct or incorrect) then the hotspot-feedback for that click is shown in the upper left corner of the screen instead of where I clicked. This could be solved by either not showing a hotspot-feedback if clicking somewhere that a hotspot-feedback already exists, or show the hotspot-feedback on top of the already existing hotspot-feedback.

Let us know what you think, do you think these are things that you should improve or do you want to make it available as it is ?

- Thomas

lukemuller

Wed, 03/15/2017 - 20:38

Thanks so much for taking the time to review this content thoroughly and testing some edge cases I hadn't considered.

I'd love to improve the content before release as some of the suggestions you made I consider are a bit 'buggy' and would prefer to release something to a higher standard and bug free.

I'll go ahead and make the changes and reply to this post when I'm happy for it to be reviewed again. Thanks again.

Luke

thomasmars's picture

thomasmars

Thu, 03/16/2017 - 08:34

Excellent, looking forward to the next version :)

lukemuller

Sun, 03/19/2017 - 22:21

Hi Thomas,

I've made some changes to the code and am happy for it to be reviwed again from my github repo. The changes were only made on this repo https://github.com/lukemuller/h5p-image-multiple-hotspot-question not the editor repo.

Thanks so much,

Luke

thomasmars's picture

thomasmars

Mon, 03/20/2017 - 10:50

Beautiful, this is working very smoothly now. Good job! :)

thomasmars's picture

thomasmars

Wed, 03/29/2017 - 14:51

We don't have a good system in place for allowing you to easily publish your own content type through our system. So for now I think the H5P Core team will just release external libraries for external developers. We will work hard to try to get a system in order for you to publish your own stuff in the near future. Does this sound okay ? We'll publish the content type together with our next official libraries release if you're okay with it.

What we need to publish this content type is an icon for it. Do you want to make one yourself or should we put a designer on the case ?

lukemuller

Wed, 03/29/2017 - 23:06

This sounds great, thanks so much!

I'm more than happy to allow a designer to create an icon for this content type. Thanks so much for taking the time to test and review my content type, I appreciate it.

Thanks

Luke

falcon's picture

falcon

Thu, 03/30/2017 - 16:24

Congratulations lukemuller, you've got developer access on H5P.org

Find Multiple Hotspots(latest from master) is installed on H5P.org and an example page has been created for you, but not published. The example content is very temporary for you to replace with awesome examples that will make people want to use your content type. 
 
Given that you're logged in you may edit the page
 
If you want multiple examples you can use the "more examples" field collection towards the bottom of the page. You'll need to include the node itself as the first entry there and then create more Interactive content nodes in a separate process that you link to from there to have several examples.
 
With the developer access, you'll also soon be able to publish new H5P content types and update the current one without any assistance. At the moment you'll just send me a message if you want to publish new content types or update the ones you already own on H5P.org and I'll install the content types for you.
 
You'll also soon get info about what you need to do to make your content type available through the H5P Hub, get usage statistics and more.
Cool stuff! Thanks a lot for contributing.

vatat

Thu, 01/24/2019 - 10:54

Hi Luke!
I love the "Image Multiple Hotspot question" 
I think it's awesome!
It would be even more awesome if it could support different languages,
or at least have the option of " Text overrides and translations" in the interface.
I'd deeply appreciate this 
All the best,
Danit

vatat

Thu, 01/24/2019 - 11:01

Hi Luke!

I love the "Image Multiple Hotspot question" 

I think it's awesome!

It would be even more awesome if it could support different languages,

or at least have the option of " Text overrides and translations" in the interface.

I'd deeply appreciate this 

All the best,

Danit

otacke's picture

otacke

Sat, 02/02/2019 - 22:14

Hi Danit!

I am not sure if Luke Muller is still working on that content type, but it's open source. Maybe someone will adopt his child.

Best,

Oliver